Skip to content

feat: apply $AWS_LAMBDA_EXEC_WRAPPER if set #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: apply $AWS_LAMBDA_EXEC_WRAPPER if set #524

wants to merge 7 commits into from

Conversation

@RomainMuller
Copy link

@RomainMuller RomainMuller commented Oct 16, 2023 •
edited
Loading

Managed AWS Lambda runtimes wrap the function's runtime entry using a script specified by the AWS_LAMBDA_EXEC_WRAPPER environment variable, however this is not performed by provided runtimes (provided, provided.al2, go1.x).

This adds a new WithEnableExecWrapper() option that re-startes the current process after wrapping it in the wrapper to emulate the behavior of other lambda runtimes, although this will cause initialization of some other go packages to be run twice, which will have an impact on cold start times.

See also: https://docs.aws.amazon.com/lambda/latest/dg/runtimes-modify.html#runtime-wrapper

Fixes #523

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RomainMuller
feat: apply $AWS_LAMBDA_EXEC_WRAPPER if set
1766dc2 
Managed AWS Lambda runtimes wrap the function's runtime entry using a script
specified by the `AWS_LAMBDA_EXEC_WRAPPER` environment variable, however this is
not performed by provided runtimes (`provided`, `provided.al2`, `go1.x`).

This adds an `init` function that re-startes the current process after wrapping
it in the wrapper to emulate the behavior of other lambda runtimes, although
this will cause initialization of some other go packages to be run twice, which
will have an impact on cold start times.

See also: https://docs.aws.amazon.com/lambda/latest/dg/runtimes-modify.html#runtime-wrapper

Fixes aws#523
@RomainMuller
lint fix
460eea2
@RomainMuller
add legacy build tagging
31a466b
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.24%. Comparing base (c4e28da) to head (d4c6b0d).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
lambda/handler.go 0.00% 7 Missing and 1 partial ⚠️
lambda/wrapper.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   72.63%   72.24%   -0.39%     
==========================================
  Files          26       27       +1     
  Lines        1407     1427      +20     
==========================================
+ Hits         1022     1031       +9     
- Misses        314      323       +9     
- Partials       71       73       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmoffatt
Copy link
Collaborator

I'm not sure about this feature. The feature could cause issues if a current or future version or provided started including built-in support for AWS_LAMBDA_EXEC_WRAPPER. Will forward the proposal on to the product team.

bmoffatt
bmoffatt reviewed Oct 26, 2023
View reviewed changes
@RomainMuller
Copy link
Author

I'm not sure about this feature. The feature could cause issues if a current or future version or provided started including built-in support for AWS_LAMBDA_EXEC_WRAPPER. Will forward the proposal on to the product team.

I would suggest the wrapper script is invoked with the AWS_LAMBDA_EXEC_WRAPPER variable clobbered, so that the child process effectively no longer has it if it's been applied already. If there is an interest in knowing whether the handler was wrapped or not, I'd introduce a new AWS_LAMBDA_EXEC_WRAPPED variable (name to be bikeshed separately) to denote that, and call it a day.

@yoelb
Copy link

yoelb commented Mar 25, 2025 •
edited
Loading

Any update regarding this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmoffatt bmoffatt bmoffatt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement stage/needs-feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for AWS_LAMBDA_EXEC_WRAPPER

4 participants

@RomainMuller @codecov-commenter @bmoffatt @yoelb